Clarify multiple IV curve requirement for Sandia fitting methods - #2883
anshurajbisoyi98-ctrl wants to merge 2 commits into
Conversation
Hey @anshurajbisoyi98-ctrl! 🎉Thanks for opening your first pull request! We appreciate your If AI is used for any portion of this PR, you must vet the content Finally, be sure the PR description includes the PR |
cwhanse
left a comment
cwhanse
left a comment
There was a problem hiding this comment.
The need to include effective irradiance and cell temperature is clear with ee and tc in the ivcurves dict.
| and cell temperature conditions. Each curve must have corresponding | ||
| effective irradiance and cell temperature data in ``ivcurves``. |
There was a problem hiding this comment.
| and cell temperature conditions. Each curve must have corresponding | |
| effective irradiance and cell temperature data in ``ivcurves``. | |
| and cell temperature conditions. |
There was a problem hiding this comment.
Thanks for the suggestion. I removed the redundant sentence from both docstrings in commit d0c2a5e.
| and cell temperature conditions. Each curve must have corresponding | ||
| effective irradiance and cell temperature data in ``ivcurves``. |
There was a problem hiding this comment.
| and cell temperature conditions. Each curve must have corresponding | |
| effective irradiance and cell temperature data in ``ivcurves``. | |
| and cell temperature conditions. |
There was a problem hiding this comment.
Thanks for the suggestion. I removed the redundant sentence from both docstrings in commit d0c2a5e.
2 participants
Both fitting-function docstrings describe per-curve arrays but do not explicitly say that multiple IV curves are required. This adds that requirement to their introductory descriptions and clarifies that each curve needs corresponding effective irradiance and cell temperature data.
Validation: 11 tests passed in the De Soto and PVsyst test modules (including both Sandia fitting tests). HTML documentation built with gallery execution disabled, and both rendered function pages were checked. The tests emit numerical/deprecation warnings; the documentation emits an existing configuration-cache warning.
remote-datawhere applicable) and Milestone are assigned to the Pull Request and linked Issue.